cleanup phase 7
This commit is contained in:
@@ -1,6 +1,6 @@
|
||||
# Decisions — the distilled engineering decision log
|
||||
|
||||
> Last verified: 2026-08-02 against commit `b876490`.
|
||||
> Last verified: 2026-08-02 against commit `51e86a1`.
|
||||
|
||||
Non-obvious decisions with a reason, extracted from `dev/`'s ~3MB of build history so they survive
|
||||
`dev/`'s move to `archive/` in phase 6. **`product/` wins for business rules** — this file is for
|
||||
@@ -91,10 +91,20 @@ Decided ui-phase-13, chosen specifically so `/` stays a stable, shareable, index
|
||||
## Engineering decisions
|
||||
|
||||
**Phase 2 → Phase 4 handoff, "the rename is filed."** The placeholder secret sentinel
|
||||
`SET_VIA_USER_SECRETS_OR_ENV` keeps its name — renaming it needs a server-code + git-hook + test change that
|
||||
is out of a documentation phase's scope, and the string is load-bearing across 7 live files. Filed as
|
||||
`SET_VIA_USER_SECRETS_OR_ENV` keeps its name — renaming it needs a server-code + test change that is out of
|
||||
a documentation phase's scope, and the string is load-bearing across several live files. Filed as
|
||||
[backlog.md](backlog.md) BL-219, deferred (cleanup-of-convenience, no urgency).
|
||||
|
||||
**Phase 7 dropped the pre-commit secret-scan hook — MVP stage, no need for it yet.** `.githooks/pre-commit`
|
||||
(the `qw123321`/private-key/AWS-key/SQL-host/connection-string scan) and `.githooks/README.md` were deleted
|
||||
outright, along with every doc reference to them (root `CLAUDE.md`'s repo-layout table and quick start,
|
||||
[git-and-gates.md](../rules/shared/git-and-gates.md), [documentation.md](../rules/documentation.md),
|
||||
[identity.md](../rules/server/identity.md), [config-matrix.md](../integration/config-matrix.md),
|
||||
[DEPLOY.md](../../DEPLOY.md)). The underlying trade this repo already made — committed live credentials,
|
||||
config in files not a secret store (root [CLAUDE.md](../../CLAUDE.md) §6) — is unchanged; this only removes
|
||||
the local mechanical backstop against a *new* leak. Revisit before onboarding real users, alongside the
|
||||
credential rotation already required by that trade.
|
||||
|
||||
**Hardening ledger re-verification (C-10) confirms the ledger was right to distrust its own checkboxes.**
|
||||
All 18 hardening items were re-traced against `b876490` rather than trusted as-filed: 3 were already fixed
|
||||
(client-only, landed in the "manual improvement" commits well before this doc chain started), 4 are
|
||||
|
||||
Reference in New Issue
Block a user