cleanup phase 1

2026-07-30 02:26:52 +03:30
parent d3ec723119
commit c889c46110
36 changed files with 4251 additions and 2552 deletions
@@ -172,4 +172,72 @@ which one file to open next for the area it is touching.

 ## Handoff

-_(filled in by the agent that runs this phase)_
+**Run 2026-07-30 against commit `d3ec723`. Complete.**
+
+### What shipped
+
+| | Before | After |
+| --- | --- | --- |
+| `client/CLAUDE.md` | 1,098 lines / 158 K | **177 lines** |
+| `server/CLAUDE.md` | 772 lines / 73 K | **184 lines** |
+| root `CLAUDE.md` | 136 lines | **164 lines** |
+| `server/CONVENTIONS.md` | 508 lines | **deleted** → `docs/rules/server/conventions.md` |
+| `client/messages/STYLE.md` | 116 lines | **deleted** → `docs/rules/client/i18n.md` §4 |
+| `docs/rules/` | 1 stub | **18 files, 3,486 lines**, every one ≤400 |
+
+The cost of opening the client rules before editing client code went from ~40k tokens to ~5k: 177 lines of
+hard rules plus one ~200-line reference file for the area you are in.
+
+### Deviations from the plan, and why
+
+1. **`docs/rules/server/money.md` is a 6th server file**, not in the Outputs tree. `persistence.md` came in
+   at 456 lines with the money content in it, over the 400-line budget this phase itself sets. Splitting the
+   money path out is the sanctioned response to overflow, and it is the most-consulted sub-topic on that
+   side — `persistence.md` is now 382 and `money.md` 244. Both `CLAUDE.md` and `rules/index.md` route to it.
+2. **`docs/rules/shared/api-conventions.md` and `money-and-types.md` were not created**, though
+   `_plan/inventory.md:134–135` assigns them owner phase 1. The phase file (lines 38–39) says **phase 2 owns
+   those two contract files** and to read them for cross-check only, and `docs/README.md` puts the wire
+   contract in `docs/integration/`. The plan file is the more specific and later instruction, so it won.
+   **Phase 2 must therefore write `docs/integration/api-contract.md`** covering the envelope, status codes,
+   casing, pagination, idempotency keys, money-on-the-wire, enum codes, PII masking, and the Shamsi
+   `day_of_week` rule. `docs/rules/index.md` already points there and says so.
+3. **`.claude/skills/frontend-designer/SKILL.md` was edited**, which the tree lists as phase 7's. C-11 could
+   not be resolved without stating precedence *in the skill*, and four of its factual claims were wrong
+   (R-3…R-5 in [open-contradictions.md](open-contradictions.md)). Only the design-language half was touched;
+   §8's workflow and §10's Figma section are untouched and still phase 7's.
+
+### Also changed, to keep the tree consistent
+
+- `AGENTS.md` ×3 — repointed at `docs/rules/`; still thin pointers (14 lines each).
+- `client/scripts/check-copy.mjs` — its doc comment now names `docs/rules/client/i18n.md` §4 (it never read
+  `STYLE.md` by path, so the delete was safe; `npm run check` confirms).
+- `server/README.md`, `server/.dockerignore` — dropped the `CONVENTIONS.md` references.
+- `server/docker-compose.yml`, `client/.env.sample` — two live files still instructed `dotnet user-secrets`.
+  Neither was on C-1's list. Fixed.
+- `docs/README.md` — `rules/` marked written.
+
+### What the next phases inherit
+
+| Phase | What phase 1 leaves it |
+| --- | --- |
+| **2** | Write `docs/integration/api-contract.md` (see deviation 2). Fix C-3's remaining half in `api-conventions.md`. The rules tree links to `docs/integration/index.md` and expects it to answer the wire contract. |
+| **3** | C-1's one genuinely wrong live doc (`manual-testing-plan.md`) is still open — phase 1 fixed two other files it didn't know about. C-3's RUNBOOK half too. |
+| **4** | **Six decisions need folding into `docs/status/decisions.md`** — the C-11 resolution and R-1…R-6, all recorded in [open-contradictions.md](open-contradictions.md) § Resolved, which is currently their only home. Also: `docs/rules/` links to `docs/status/backlog.md` for the 7 mock-blocking REQs and to `docs/status/` as the mock registry's new home. And one drift worth a backlog item: `client/src/services/payment/constants.ts` has `MOCK_PLATFORM_FEE_RATE = 0.12`, while refinement-phase-3 settled the canonical model at 0.15 — mock-only today, but it will lie on a checkout screenshot. |
+| **6** | The `dev/`-lane handoff protocol (STATUS.md, `for-backend.md`, per-phase reports, the "save memory" step) was deliberately **not** carried into `docs/rules/` — the parallel-agent chain is finished. Its durable half (contract-first, record every mock) is in `documentation.md`. |
+| **7** | Owns the pre-commit warning that enforces `documentation.md` §2, and the rest of the skill. C-12's non-design half is still open. |
+
+### Verification
+
+- [x] `client/CLAUDE.md` 177 lines, `server/CLAUDE.md` 184 — both under 250.
+- [x] 20 ledger rules spot-checked for single-home placement; the 6 stale ones are gone from every file.
+- [x] No rule describes pre-iteration-1/2 client behaviour (R-1…R-6 rewritten against the code).
+- [x] `grep -rn "user-secrets"` over tracked `client/ server/ CLAUDE.md docs/` returns only statements that
+      it is **not** used (plus `_plan/`'s own descriptions of the contradiction).
+- [x] `cd client && npm run check` passes — `check-copy: 2005 strings checked, 0 banned variants found.`
+- [x] All 3 `AGENTS.md` resolve; a link check over all 27 new/changed markdown files found 0 broken links.
+- [x] C-11 resolved with its decision; C-3 and C-12 marked partly resolved with what remains and to whom.
+
+The Step-1 rule ledger (109 numbered rules across 11 groups, each tagged with source, scope, tier,
+destination and state) was scratch by design and is not committed, per the phase brief. Its content is fully
+represented in the output files; the six corrections and two count fixes it surfaced are recorded durably in
+[open-contradictions.md](open-contradictions.md) § Resolved.